Skip to content

Conversation

@hatcat
Copy link
Contributor

@hatcat hatcat commented Mar 2, 2021

Closes #1707.

@hatcat hatcat requested a review from a team as a code owner March 2, 2021 09:27
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 2, 2021
@StephanTLavavej StephanTLavavej changed the title Closes #1707 Update _MSVC_STL_UPDATE to March 2021 Mar 2, 2021
@StephanTLavavej
Copy link
Member

Thanks! We have a two-review process (even for one-line changes 😹) so I'll find a second maintainer to approve and then this will be ready to merge. I was just about to prepare a batch of merges for VS 2019 16.10 Preview 2 so I can add your change.

A couple of logistical issues:

  • GitHub is surprisingly picky about the close/fix/resolve syntax - you have to say the magic words in the PR description. They have no effect in the PR title; in commit messages they create "mentions" but not the connection that makes the PR auto-close the issue. I've edited your PR description, and now the issue appears in the "Linked issues" section of the sidebar.
  • I've edited the PR title to be descriptive; this makes it easier to see what PRs are doing when we have 20+ of them open (see the Code Reviews project for what that looks like).

@hatcat
Copy link
Contributor Author

hatcat commented Mar 2, 2021

Many thanks for your clarification. I hope to make further contributions (including the Linear Algebra proposal when it finally makes its way out of LEWG, LWG and plenary, which will be about 2027 at this rate...) so I will be keeping abreast of the rules. I suppose I should read the wiki too...!

Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Guy - welcome to the STL!

@StephanTLavavej StephanTLavavej merged commit 108a112 into microsoft:main Mar 2, 2021
@StephanTLavavej
Copy link
Member

Thanks for updating this version number; it'll ship in VS 2019 16.10 Preview 2. Congratulations on your first microsoft/STL commit! 🎉 🥳 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to March 2021

3 participants